Initial package development #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Mike Lippincott <58147848+MikeLippincott@users.noreply.github.com>
MikeLippincott
approved these changes
Jan 24, 2025
Member
MikeLippincott
left a comment
MikeLippincott
left a comment
There was a problem hiding this comment.
LGTM. Thank you for packaging this. I really like the work that was been done thus far. I made some comments, feel free to address them how you see fit.
This was referenced Jan 24, 2025
Co-authored-by: Mike Lippincott <58147848+MikeLippincott@users.noreply.github.com>
Co-Authored-By: Mike Lippincott <58147848+MikeLippincott@users.noreply.github.com>
Member
Author
|
Thank you @MikeLippincott! After making changes based on your comments I'll now merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates prototype materials into a formal Python package for creating and viewing n-dimensional image files.
This includes:
nVizpackage itselfThanks for any thoughts or feedback you may have!
Upon approval and merge of this PR, excepting any errors which need to be fixed afterward, I'll make the first release (
0.0.1) on GitHub which will in turn automatically release this on PyPI.Closes #1