Skip to content

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented Apr 25, 2025

Description

This PR adds a CLI for nviz with commands for converting from TIFF sets to Zarr, OME-TIFF, and viewing both file formats.

Depends on #35 to succeed with tests.

Note: I've modified the coverage configuration to ignore certain test files which were causing challenges based on how our Linux CI is configured for this project (headless display properties for Napari tests).

Thanks for any feedback!

Closes #21

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs marked this pull request as ready for review April 25, 2025 18:56
Copy link
Member

@MikeLippincott MikeLippincott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mionor comments

d33bs and others added 3 commits April 26, 2025 06:53
Co-Authored-By: Mike Lippincott <58147848+MikeLippincott@users.noreply.github.com>
@d33bs
Copy link
Member Author

d33bs commented Apr 28, 2025

Note: I've modified the coverage configuration to ignore certain test files which were causing challenges based on how our Linux CI is configured for this project (headless display properties for Napari tests).

@d33bs
Copy link
Member Author

d33bs commented Apr 28, 2025

Thanks @MikeLippincott ! After making some changes here I'll now merge this in.

@d33bs d33bs merged commit 47195c2 into WayScience:main Apr 28, 2025
5 checks passed
@d33bs d33bs deleted the add-cli branch April 28, 2025 15:54
MikeLippincott added a commit to MikeLippincott/nViz that referenced this pull request Sep 29, 2025
* add nviz cli

* [pre-commit.ci lite] apply automatic fixes

* updates based on feedback

Co-Authored-By: Mike Lippincott <58147848+MikeLippincott@users.noreply.github.com>

* ignore testing utils

* ignore conftest for coverage

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Mike Lippincott <58147848+MikeLippincott@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add command-line interface (CLI)

2 participants