Add path_report capability to help observe file and directory challenges
#42
Conversation
d33bs
changed the title
path_report capability to help observe file and directory challenges
jenna-tomkinson
left a comment
jenna-tomkinson
left a comment
There was a problem hiding this comment.
LGTM! All these tests are very good and I think the only other comment I have is that in the documentation it should be noted that these tests work best when the images are in a certain format (e.g., per plate, each folder is a individual well and FOV combo).
Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
|
Thanks @jenna-tomkinson !
Thanks for these thoughts - I'm going to leave the documentation as-is for now to keep this flexible to how things might develop. Generally my hope is that this can work for either (or any) case based on how we configure things. I think #45 might be useful when it comes to this - among other solutions. |
…enges (WayScience#42) * Create check.py * path report capabilities * linting * [pre-commit.ci lite] apply automatic fixes * remove pull_request set of testion actions * Update .pre-commit-config.yaml * Update .pre-commit-config.yaml * use pull request src instead of target for chkout * add debug for actions * remove debug * update to avoid coverage discrepancies * Update coverage-badge.svg * move to macos for pre-commit checks * linting * ignore tests for coverage * remove coverage reporting * remove shellcheck because of docker * add path reporter to cli * update for return code expectations * add complete test data * update for tests and readd coverage just in case * test locally * Update run-tests.yml * Update coverage-badge.svg * Update coverage-badge.svg * readd coverage Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com> * Update .pre-commit-config.yaml --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
2 participants
Description
This PR adds a "path reporter" to help observe various challenges @jenna-tomkinson had mentioned appear within image datasets. This doesn't cover all the issues and instead is just a start towards this (the complexity of the others might warrant a separate or multiple other PR's).
References #28
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.