Skip to content

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented Sep 9, 2025

Description

This PR attempts to fix the CI error we see about a git command failing. The command fails due to a space in the URL reference for the upstream which is added to avoid a long command (obeying yamllint conventions). This fix ignores the lint rule to help the command succeed. It will fail within this PR because of how the file is referenced by CI (from main until merged).

Reference of error: https://github.com/WayScience/nViz/actions/runs/17565759927/job/49892270110?pr=55

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs marked this pull request as ready for review September 9, 2025 15:18
@d33bs d33bs requested a review from MattsonCam September 10, 2025 14:57
Copy link
Member

@MattsonCam MattsonCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @d33bs, nice small pr!

@d33bs
Copy link
Member Author

d33bs commented Sep 13, 2025

Thanks @MattsonCam !

@d33bs d33bs merged commit 52d478b into WayScience:main Sep 13, 2025
4 of 5 checks passed
@d33bs d33bs deleted the fix-ci branch September 13, 2025 16:51
MikeLippincott pushed a commit to MikeLippincott/nViz that referenced this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants