Skip to content

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented Jan 24, 2025

Description

This PR updates the CI to run using passing tests, avoiding certain OS dependency and Napari-based errors which occur (see #8). As a result we're not covered by Linux tests currently and I will plan to follow up soon to address this. I feel that this may be a result of the GitHub Actions containers but will need to gather more information here.

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs marked this pull request as ready for review January 24, 2025 23:30
@d33bs d33bs requested a review from gwaybio January 24, 2025 23:30
@d33bs
Copy link
Member Author

d33bs commented Jan 25, 2025

Thanks @gwaybio ! Merging this in.

@d33bs d33bs merged commit 48256a2 into WayScience:main Jan 25, 2025
3 checks passed
@d33bs d33bs deleted the fixes branch January 25, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants