-
Notifications
You must be signed in to change notification settings - Fork 3
Add analysis module #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just realized it might be useful to show well or plate for UMAP colors, which could indicate/disprove any plate/image effects on features. I will implement this and let you know when done. |
gwaybio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A couple general comments:
- I like that you saved the UMAP coordinates, will you use these to generate publication-ready figures later? (I noticed that you didn't save the actual UMAP images)
- Does
format_training_data.ipynbneed a number prefix? (i.e. does it need to be executed in a specific order?)
Co-authored-by: Gregory Way <gregory.way@gmail.com>
|
Probably. It wouldn't hurt. |
@gwaybio This is ready for review!