Adding figure 3 and associated notebook #39
Conversation
gwaybio
commented
Sep 29, 2023
gwaybio
commented
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jenna-tomkinson
left a comment
jenna-tomkinson
left a comment
There was a problem hiding this comment.
Great PR! I like how it is pretty easy to understand and end plot looks awesome to tell a clear story about performance.
I had one question to address but LGTM!
|
|
||
| head(cm_df) | ||
|
|
||
| custom_labeller <- function(value) { |
There was a problem hiding this comment.
Is it required that you need to make this custom labeller or could you just label each row as "final" or "shuffled"?
There was a problem hiding this comment.
Great question! Labeling each row is one way to do it. Is this what you would prefer? To me, Shuffled: FALSE is more clear than Final, but it is definitely clunkier :/
There was a problem hiding this comment.
I can see both sides! I think I will default to what you think since you have more experience with how readers interpret figures. Shuffled: FALSE is still very clear and I think that someone can put 2 and 2 together to know that represents the final model.
2 participants
