Skip to content

Conversation

@gwaybio
Copy link
Member

@gwaybio gwaybio commented Oct 3, 2023

supplementary_singleclassmodel_evaluations

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I had a question regarding how to interpret the figure, but overall great PR!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments on how the figure looks! I wanted to confirm my observations are correct.

The single-class models are not that good at all compared to the multi-class. Which is weird, since one analysis Roshan did showed that both model types per phenotypic class weight similar features the same.

I am assuming we will reference this in the results with one sentence essentially saying that the single-cell models performed poorly (Supplementary figure #), right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are correct. One potential explanation may be revealed by @MattsonCam analysis of class balanced models.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming we will reference this in the results with one sentence essentially saying that the single-cell models performed poorly (Supplementary figure #), right?

Yep, so far this is our strategy

@gwaybio gwaybio merged commit 4f09553 into WayScience:main Oct 19, 2023
@gwaybio gwaybio deleted the sup-fig-evals branch October 19, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants