Add class pr curves #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* finish download module changes * download notebook * rerun split data module * rerun download module * rerun train_model * rerun evaluation module * rerun interpretation module * combine datasets * combine datasets * split changes * update format * format update * format * finish split data * combine datasets, remove holdout * formatting * rerun pipelines * remove folded class * rerun pipeline * Update utils/download_utils.py Co-authored-by: Dave Bunten <ekgto445@gmail.com> * PR fixes * module docstrings Co-authored-by: Dave Bunten <ekgto445@gmail.com>
gwaybio
approved these changes
Dec 12, 2022
Member
gwaybio
left a comment
gwaybio
left a comment
There was a problem hiding this comment.
LGTM! Thanks for such a nice, bite-sized PR. Happy to take another look prior to merging if you'd like
d33bs
reviewed
Dec 12, 2022
Member
d33bs
left a comment
d33bs
left a comment
There was a problem hiding this comment.
Nice work! I left a few minor comments but things mostly looked good to me. Please don't hesitate to let me know if you have any questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for review! This PR creates precision-recall curves for every phenotypic class using the final and shuffled baseline models on the training and testing data.