fix error handling in ipc client and add safety checks#337
Merged
soreau merged 1 commit intoWayfireWM:masterfrom Feb 17, 2026
Merged
fix error handling in ipc client and add safety checks#337soreau merged 1 commit intoWayfireWM:masterfrom
soreau merged 1 commit intoWayfireWM:masterfrom
Conversation
AKArien
force-pushed
the
fix-ipc
branch
2 times, most recently
from
5a97d25 to
befba5b
Compare
soreau
approved these changes
Feb 17, 2026
Member
soreau
left a comment
soreau
left a comment
There was a problem hiding this comment.
LGTM. Aside from the nitpicks, this is certainly an improvement.
| ipc_client->send("{\"method\":\"wayfire/get-keyboard-state\"}", [=] (wf::json_t data) | ||
| { | ||
| if (data.serialize().find( | ||
| "error") != std::string::npos) |
Member
There was a problem hiding this comment.
Did uncrustify separate this into two lines? Doesn't seem necessary..
src/util/wf-ipc.cpp
Outdated
Member
There was a problem hiding this comment.
Hm, should we output the socket_path here?
Member
|
Thanks! |
if ipc isn’t available on language widget, don’t render it fixes WayfireWM#336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.