-
-
Notifications
You must be signed in to change notification settings - Fork 341
Necessary updates due to the latest Wrath talent configuration changes. #6119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Necessary updates due to the latest Wrath talent configuration changes.
|
Why does this remove holy resistance? And what's the context of the other changes? |
Although Holy Resistance exists as a stat in the game, it doesn’t have any meaningful value for players to monitor, so I hid it. If you think it should be kept, I can discard this change. |
|
The reason I submitted this PR is that the changes to Modernize need to be released as soon as possible together with the Wrath talent changes; otherwise, it could cause issues. |
|
Can you make a separate PR for the OnBeforeReload/OnAfterReload fix? I think at first glance it looked good, and if it's the same as TWW, I would just merge it. |
|
I just saw your reply, and then noticed that nomore has just submitted the same changes you mentioned, so I didn’t submit them again. |
Necessary updates due to the latest Wrath talent configuration changes.