Skip to content

Conversation

@barneyng
Copy link
Contributor

Necessary updates due to the latest Wrath talent configuration changes.

Necessary updates due to the latest Wrath talent configuration changes.
@InfusOnWoW
Copy link
Contributor

Why does this remove holy resistance? And what's the context of the other changes?

@barneyng
Copy link
Contributor Author

barneyng commented Dec 16, 2025

Why does this remove holy resistance? And what's the context of the other changes?

Although Holy Resistance exists as a stat in the game, it doesn’t have any meaningful value for players to monitor, so I hid it. If you think it should be kept, I can discard this change.
The changes to minitalent_wrath in the options were based on minitalent_TWW, so that clicking an icon won’t immediately close the minitalent window; otherwise, the user experience of this interface would be very poor.
The changes to Types.lua are mostly driven by my OCD, just to make the format look more consistent.
As for the changes to Modernize.lua, they were discussed with Nomore and further optimized a few hours ago.

@barneyng
Copy link
Contributor Author

The reason I submitted this PR is that the changes to Modernize need to be released as soon as possible together with the Wrath talent changes; otherwise, it could cause issues.

@InfusOnWoW InfusOnWoW merged commit e07dc85 into WeakAuras:main Dec 19, 2025
3 checks passed
@InfusOnWoW
Copy link
Contributor

Can you make a separate PR for the OnBeforeReload/OnAfterReload fix? I think at first glance it looked good, and if it's the same as TWW, I would just merge it.

@barneyng
Copy link
Contributor Author

barneyng commented Dec 20, 2025

I just saw your reply, and then noticed that nomore has just submitted the same changes you mentioned, so I didn’t submit them again.
This time, my submission was mainly to make sure that the changes to modernize and internalVersion would be synced by the Dev team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants