Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6096
This PR adds The Burning Crusade (TBC) support and includes several refactors and fixes required to make WeakAuras function correctly on TBC realms.
Overall, TBC support appears stable on PTR and no major issues are expected, but the points listed below in the Maintainer Notes are worth being aware of.
Type of change
How Has This Been Tested
Details / Notes
Private.event_prototypesfor expansion checksAddMessageEventFilternow works correctly on TBCPrivate.power_typescleanup and table refactorMaintainer Notes / Open Points
This PR includes TBC support and works correctly on PTR in its current state. That said, there are a few open points worth calling out explicitly:
TalentWidget edge cases
Importing a class that does not exist on TBC (e.g. Death Knight) currently causes errors.
This can be purged and does not block TBC support.
A fix has been added here:
https://github.com/WeakAuras/WeakAuras2/compare/eaf439b50fad4bbf8aa58ee72b33573a3a1fa8f6..67a3f2617ce1e7a93d1315482fd6d26b56a5fa78
More critically: when switching talent widgets while a talent index is selected that no longer exists (due to class change or import), the widget will still attempt to validate that index.
As a result, the aura may fail to load or trigger.
https://github.com/WeakAuras/WeakAuras2/compare/eaf439b50fad4bbf8aa58ee72b33573a3a1fa8f6..67a3f2617ce1e7a93d1315482fd6d26b56a5fa78
Modernizer & merge order
Pet Power: Happiness
Model
Checklist