Skip to content

Conversation

@NoM0Re
Copy link
Contributor

@NoM0Re NoM0Re commented Jan 2, 2026

Description

Fixes #6096

This PR adds The Burning Crusade (TBC) support and includes several refactors and fixes required to make WeakAuras function correctly on TBC realms.
Overall, TBC support appears stable on PTR and no major issues are expected, but the points listed below in the Maintainer Notes are worth being aware of.

Type of change

  • New Expansion

How Has This Been Tested

  • Tested on TBC PTR
  • Verified most aura loading, triggering, ...

Details / Notes

  • Wrath Mini Widget is reused in both Load and Trigger for TBC
  • Init refactor to make the structure clearer (still large, but more maintainable)
  • Small refactor under Private.event_prototypes for expansion checks
  • AddMessageEventFilter now works correctly on TBC
  • Private.power_types cleanup and table refactor
  • Proc Glow exists on TBC 🎉
  • Models regenerated, but it is already a few builds old
  • Arthas is currently missing; temporarily replaced with Illidan

Maintainer Notes / Open Points

This PR includes TBC support and works correctly on PTR in its current state. That said, there are a few open points worth calling out explicitly:

TalentWidget edge cases

Modernizer & merge order

  • The currently committed Modernizer should also apply to TBC.
  • Because of this, it would be cleaner to merge TBC before tagging, although this is not a hard requirement.

Pet Power: Happiness

  • Currently not supported at all.
  • Should be implemented as a proper power type.
  • Missing not only for TBC, but also for Classic and Wrath.

Model

  • Arthas model is missing and temporarily replaced with Illidan.
  • Feedback welcome on whether this is acceptable or should be reverted.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@NoM0Re NoM0Re force-pushed the tbc-anni branch 3 times, most recently from eaf439b to 67a3f26 Compare January 3, 2026 16:25
@NoM0Re NoM0Re marked this pull request as ready for review January 3, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Addon not loading for TBC Anniversary (PTR Version)

2 participants