Skip to content

feat: overwrite error.stack when ReactNative flag is set #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaitanyapotti merged 3 commits into from
Feb 6, 2024
Merged

feat: overwrite error.stack when ReactNative flag is set #292

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4eb5b4d
feat: overwrite error.stack when ReactNative flag is set
ieow Feb 2, 2024
88ed87f
fix: lints
ieow Feb 2, 2024
f31ce09
fix: use simpler fix
ieow Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/openlogin-jrpc/src/jrpcEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ export class JRPCEngine extends SafeEventEmitter {
const end: JRPCEngineEndCallback = (err?: unknown) => {
const error = err || res.error;
if (error) {
if (Object.keys(error).includes("stack") === false) error.stack = "Stack trace is not available.";

res.error = serializeError(error, {
shouldIncludeStack: true,
fallbackError: {
Expand Down Expand Up @@ -319,6 +321,8 @@ export class JRPCEngine extends SafeEventEmitter {
// Ensure no result is present on an errored response
delete res.result;
if (!res.error) {
if (Object.keys(error).includes("stack") === false) error.stack = "Stack trace is not available.";

res.error = serializeError(error, {
shouldIncludeStack: true,
fallbackError: {
Expand Down Expand Up @@ -411,6 +415,8 @@ export function providerFromEngine(engine: JRPCEngine): SafeEventEmitterProvider
provider.sendAsync = async <T, U>(req: JRPCRequest<T>) => {
const res = await engine.handle(req);
if (res.error) {
if (Object.keys(res.error).includes("stack") === false) res.error.stack = "Stack trace is not available.";

const err = serializeError(res.error, {
fallbackError: {
message: res.error?.message || res.error?.toString(),
Expand Down