Skip to content

fixes redirect in manage MFA #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaitanyapotti merged 1 commit into from
May 6, 2025
Merged

fixes redirect in manage MFA #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/core/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,6 @@ export class Auth {
// in case of redirect mode, redirect url will be dapp specified
// in case of popup mode, redirect url will be sdk specified
const defaultParams = {
redirectUrl: `${this.dashboardUrl}/wallet/account`,
dappUrl: `${window.location.origin}${window.location.pathname}`,
};

Expand All @@ -347,7 +346,12 @@ export class Auth {
const dataObject: AuthSessionConfig = {
actionType: AUTH_ACTIONS.MANAGE_MFA,
// manage mfa always opens in a new tab, so need to fix the uxMode to redirect.
options: { ...this.options, uxMode: "redirect", sdkMode: SDK_MODE.DEFAULT },
options: {
...this.options,
uxMode: UX_MODE.REDIRECT,
sdkMode: SDK_MODE.DEFAULT,
redirectUrl: `${this.dashboardUrl}/wallet/account`,
},
params: {
...defaultParams,
...params,
Expand Down
Loading