-
Notifications
You must be signed in to change notification settings - Fork 11
import sfa key #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
import sfa key #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ieow
reviewed
Dec 10, 2024
ieow
reviewed
Dec 10, 2024
ieow
approved these changes
Dec 11, 2024
Contributor
ieow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ieow
reviewed
Dec 11, 2024
Contributor
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This pr allows users to import existing sfa users to mfa.
Jira Link:
Description
This PR adds a new parameter named
registerExistingSFAKeyin login function. If this param is set to true thn it sfa key will be imported to mpc.Few things to consider:-
Once sfa key is imported, key wont be accesible from sfa sdks.
If you reset your MPC account, you cant access it from SFA again.
Also this function will throw error if sfa key was generated for v1 sfa user. Upgrading for v1 users is not possible at all so we should mention this in docs such that application can handle this case while registering sfa user.
This doesn't work for redirect flow, there is a bug in mpc core kit which doesn't handles redirect import case, so i have added it to throw an error if import key flow is used in redirect mode. We will remove the error once the redirect flow is fixed.
How has this been tested?
I have added one new test which creates a SFA key, than sets
registerExistingSFAKeyin mpc core kit so that mpc core kit import sfa key.Later test tries to login with sfa again and sfa key should be empty, where as mpc exported key should match existing sfa key.
This PR affects, loginWithJwt, loginWithOauth and setupTkey functions
Screenshots (if appropriate):
Types of changes
Checklist: