Skip to content

Conversation

@grvgoel81
Copy link
Collaborator

@grvgoel81 grvgoel81 commented Nov 11, 2024

Motivation and Context

  • Make signatures accessible by dapps from torus-utils-java.
  • Return error and Completable from logout function.
  • Update initialize function return type.

Jira Link: https://toruslabs.atlassian.net/browse/PD-4154

Description

  • Make signatures accessible by dapps from torus-utils-java.
  • Return error and Completable from logout function.
  • Update initialize function return type.

How has this been tested?

  1. Tested by devrel.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

grvgoel81 and others added 4 commits November 8, 2024 08:51
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit e81c0e1 into master Dec 4, 2024
2 checks passed
grvgoel81 added a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants