Skip to content

Conversation

@arch1995
Copy link
Contributor

@arch1995 arch1995 commented Oct 14, 2024

Motivation and Context

We want to remove extra deps for react native and nodejs backend. Hence we allow sfa web to accept various new params like mode and storage to customise sdk usage.

Jira Link: https://toruslabs.atlassian.net/browse/PD-4010

Description

  • Accept two new params in the constructor - mode, and storage.
  • Defines a async storage to save sfa data.

How has this been tested?

Developer and devrels tested this.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arch1995 arch1995 self-assigned this Oct 14, 2024
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@yashovardhan yashovardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. All examples work as expected

@chaitanyapotti chaitanyapotti merged commit 9cb5d5e into master Oct 25, 2024
@chaitanyapotti chaitanyapotti deleted the feat/multi-sdk-support branch October 25, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants