Skip to content

Feat/pd 4086 Update tests #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chaitanyapotti merged 4 commits into from
Nov 25, 2024
Merged

Feat/pd 4086 Update tests #70

chaitanyapotti merged 4 commits into from
Nov 25, 2024

Conversation

@hieu-w
Copy link
Member

@hieu-w hieu-w commented Nov 24, 2024 •
edited
Loading

Motivation and Context

Jira Link:

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@hieu-w hieu-w changed the title Feat/pd 4086 add more tests for node & web environment in single factor auth sdk Feat/pd 4086 Update tests Nov 24, 2024
chaitanyapotti
chaitanyapotti approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit aa52a91 into master Nov 25, 2024
3 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/PD-4086-Add-more-tests-for-node-&-web-environment-in-single-factor-auth-sdk branch November 25, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hieu-w @chaitanyapotti