Skip to content

Conversation

@grvgoel81
Copy link
Contributor

Motivation and Context

  • Delete sessionId from KeyStoreManager in case of invalid/expired sessionId.

Jira Link:

Description

  • Delete sessionId from KeyStoreManager in case of invalid/expired sessionId.

How has this been tested?

  • Testing on emulator.

Screenshots (if appropriate):

Screenshot 2024-12-02 at 9 22 55 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

Signed-off-by: Gaurav Goel <gaurav@tor.us>
@metalurgical
Copy link
Contributor

This looks fine. Are we sure we want to throw the error in initialize still on invalid session? Isn't it fine to leave it as empty because it will be recreated on login again like swift?

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 76ca316 into master Dec 2, 2024
2 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/minor-fix branch December 2, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants