Skip to content

Conversation

@BboyStatix
Copy link
Contributor

@BboyStatix BboyStatix commented Dec 1, 2025

Motivation and Context

Jira Link: https://consensyssoftware.atlassian.net/browse/W3APD-5181

Description

The more wallets button is missing when total wallets count is 15 or below. This prevents a user from ever seeing the other wallets that they have.

  • This PR changes the behaviour such that if it is 15 wallets or below we automatically show the expanded list instead of showing the more wallets button.
  • In doing so we also fix the weird looking UI of there being a lot of blank whitespace between recommended wallets and the more wallets button.

How has this been tested?

Screenshots (if appropriate):

Before

Screenshot 2025-12-01 at 6 18 45 PM

After

Screenshot 2025-12-01 at 6 19 00 PM

NOTE: The case of there being few recommended wallets still results in whitespace though.
Screenshot 2025-12-01 at 6 38 18 PM
If we were to fix this though it would mean that we check only that default/recommended wallets <= 15 to auto-expand the list. But that would be bad for performance as that would mean user going to this page would on mount load potentially 400 wallets into the list.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@BboyStatix BboyStatix self-assigned this Dec 1, 2025
@vercel
Copy link

vercel bot commented Dec 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web3auth-web Ready Ready Preview Comment Dec 1, 2025 10:20am

@BboyStatix BboyStatix requested a review from smgv December 1, 2025 10:16
@BboyStatix BboyStatix marked this pull request as ready for review December 1, 2025 10:19
@BboyStatix BboyStatix changed the title Fix external wallets list to show other wallets when total count is 15 or below Fix external wallets list to automatically show other wallets when total count of wallets is 15 or below Dec 1, 2025
Copy link
Contributor

@smgv smgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BboyStatix BboyStatix merged commit c45fe37 into master Dec 1, 2025
6 checks passed
@BboyStatix BboyStatix deleted the feat/defi-positions branch December 1, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants