Skip to content

Rename acces to access #209#211

Merged
sunfishcode merged 1 commit intoWebAssembly:masterfrom
denisvasilik:denisvasilik/function-error-code-209
Feb 19, 2020
Merged

Rename acces to access #209#211
sunfishcode merged 1 commit intoWebAssembly:masterfrom
denisvasilik:denisvasilik/function-error-code-209

Conversation

@denisvasilik
Copy link
Contributor

This pull request is part of issue #209.

@kubkon kubkon requested review from sbc100 and sunfishcode January 22, 2020 09:53
@sunfishcode
Copy link
Member

This makes sense to me. There's evidence that people commonly spell this one access despite the POSIX spelling:

https://lore.kernel.org/patchwork/patch/1003891/
https://lore.kernel.org/patchwork/patch/1079508/
https://lkml.org/lkml/2019/5/27/185

Of course, WASI libc will need to continue to expose this as EACCES, because that is the POSIX name. So the primary effect of this name change will be to make the documentation more clear, but that seems worth it to me here.

@sunfishcode sunfishcode merged commit 445aeb7 into WebAssembly:master Feb 19, 2020
@sunfishcode
Copy link
Member

Thanks!

yoshuawuyts pushed a commit to yoshuawuyts/WASI that referenced this pull request Nov 25, 2025
yoshuawuyts pushed a commit to yoshuawuyts/WASI that referenced this pull request Nov 25, 2025
yoshuawuyts pushed a commit to yoshuawuyts/WASI that referenced this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants