[do not merge] Preview adding @since and @unstable gates to WASI 0.2#604
Closed
yoshuawuyts wants to merge 9 commits intoWebAssembly:mainfrom
Closed
[do not merge] Preview adding @since and @unstable gates to WASI 0.2#604yoshuawuyts wants to merge 9 commits intoWebAssembly:mainfrom
@since and @unstable gates to WASI 0.2#604yoshuawuyts wants to merge 9 commits intoWebAssembly:mainfrom
Conversation
This was referenced May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to help create confidence in the implementation of
@sinceand@featurein wasm-tools, this PR adds@sincegates to the entirety of the WASI 0.2 API surface area. As well as bringing in thewit:clockstimezone surface area introduced in WebAssembly/wasi-clocks#61 under an@unstableattribute.This PR is not intended to be merged, but to mainly to validate the implementation and to give an idea of what the resulting semantics of that will be in practice.
Validating the implementation
Using a local build of the
wasm-toolsbranch, do:This will warn
wasm-toolsnot knowing where to findwasi:io, but it will not throw any errors about@sinceor@featuregates not parsing.Next steps
Speaking concretely about the implementation: I'll split this PR up into several
sub-PRs on the correct sub-repositories. Those can't be merged until the
@sinceand@featuregate functionality is merged - but hopefully with thisdraft PR we can get one step closer in building confidence that it will work out
as expected.