Add Clocks: Timezone as a stage 0 proposal#605
Merged
sunfishcode merged 1 commit intoWebAssembly:mainfrom May 30, 2024
Merged
Conversation
This was referenced May 29, 2024
ricochet
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a stage 0 proposal to extend
wasi:clockswith basic timezone support. @sunfishcode is the current champion forwasi:clocksand has volunteered to also be the champion for this extension. The related PR for this on thewasi:clocksside are: WebAssembly/wasi-clocks#61 and cdmurph32/wasi-clocks#1.This proposal is a little different from the other proposals so far: rather than introducing something new, this extends an existing stage 3 proposal. The expectation is that we will want to advance this independently from
wasi:clocksthrough the phase process, and will be voted on by the SG. Tracking this independently gives us the flexibility we need for that.Additionally, this also gives the
timezoneproposal a concrete name. Now that@unstablehas landed in the component model, we can use the name of the proposal as the name of the feature gate. In this case that would mean we would gate this extension using theclocks-timezonefeature name.I hope this all makes sense. I've also filed WebAssembly/meetings#1594 to discuss this all in more detail in tomorrow's SG meeting. Thanks!