Open
Conversation
- Limit the prose to about 80 characters per line.
- Describe POSIX equivalents of the error codes.
- Removed outdated `stream` info from:
- `resolve-addresses`
- `tcp-socket::receive`
- Describe shared ownership semantics of sockets and their streams/futures as we landed on in #870
- Capture the "lessons learned" so far:
- TCP & UDP `connect` may update the socket's local address. See bytecodealliance/wasmtime#12589
- TCP `bind` should always set SO_REUSEADDR. See bytecodealliance/wasmtime#12402
- send/receive buffer sizes may be dynamically adjusted by the OS. See bytecodealliance/wasmtime#12561
- Windows does not perform an implicit bind on UDP `send`.
badeend
force-pushed
the
bind-always-reuseaddr
branch
from
f301996 to
a71263a
Compare
badeend
changed the title
tcp-socket::bind: Drop the "When binding to a non-zero port" condition
ricochet
reviewed
Feb 24, 2026
ricochet
reviewed
Feb 24, 2026
ricochet
reviewed
Feb 24, 2026
ricochet
reviewed
Feb 24, 2026
ricochet
reviewed
Feb 24, 2026
ricochet
reviewed
Feb 24, 2026
ricochet
reviewed
Feb 24, 2026
Co-authored-by: Bailey Hayes <ricochet@users.noreply.github.com>
Co-authored-by: Bailey Hayes <ricochet@users.noreply.github.com>
Member
Author
|
@ricochet Thanks for the textual improvements. I've accepted them all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update sockets documentation:
stream/error-contextinfo from:resolve-addressestcp-socket::receiveconnectmay update the socket's local address. See [wasi-sockets] reconnecting UDP socket unexpectedly changes local address bytecodealliance/wasmtime#12589bind(except on Windows). See SO_REUSEADDR should be set on TCP sockets even when not binding to a specific port bytecodealliance/wasmtime#12402send. See wasi-sockets: Allow implicit binds in 0.3 bytecodealliance/wasmtime#12225