Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

[spec/interpreter/test] Spec & implement proposal#4

Merged
rossberg merged 6 commits intomasterfrom
all
May 13, 2019
Merged

[spec/interpreter/test] Spec & implement proposal#4
rossberg merged 6 commits intomasterfrom
all

Conversation

@rossberg
Copy link
Member

This should include everything necessary for stage 3:

  • Specify syntax of annotations.
  • Implement annotation parsing in interpreter.
  • Test for annotation parsing.
  • Bonus: specify @name and @Custom annotations in spec appendix.

Like with the custom sections, the interpreter only implements generic parsing of annotation syntax and otherwise ignores it.

@rossberg rossberg requested a review from lukewagner April 27, 2019 22:01
@rossberg
Copy link
Member Author

@lukewagner, friendly ping.

Copy link
Member

@lukewagner lukewagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I missed this review request. lgtm

@rossberg rossberg merged commit 1a33be6 into master May 13, 2019
@rossberg rossberg deleted the all branch May 13, 2019 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants