Conversation
kripken
reviewed
Jul 7, 2017
| @@ -50,6 +50,7 @@ struct Visitor { | |||
| ReturnType visitLoad(Load* curr) {} | |||
| ReturnType visitStore(Store* curr) {} | |||
| ReturnType visitAtomicRMW(AtomicRMW* curr) {return ReturnType();} //Stub impl so not every pass has to implement this yet. | |||
Member
There was a problem hiding this comment.
Could we make all these functions have the return, I believe we decided that was best?
Also, please add spaces after { and before }.
Member
Author
There was a problem hiding this comment.
I have a local branch with that change which I'll submit as a separate PR because it depends on this one (I already had this branch in flight when we decided that).
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.