Refactor validation failure and printing, validate atomic alignment#1090
Merged
Refactor validation failure and printing, validate atomic alignment#1090
Conversation
kripken
reviewed
Jul 12, 2017
|
|
||
| namespace wasm { | ||
|
|
||
| // Print anything that can be streamed to an ostream |
Member
There was a problem hiding this comment.
perhaps these two could go in wasm-printing.h?
Member
Author
There was a problem hiding this comment.
I thought about that but they are kind of specific to the validator where we want to easily make everything print with the extra type info. Otherwise they sort of just duplicate the stream-related functions there.
src/wasm/wasm-validator.cpp
Outdated
| shouldBeEqualOrFirstIsUnreachable(curr->value->type, curr->valueType, curr, "store value type must match"); | ||
| } | ||
| void WasmValidator::visitAtomicRMW(AtomicRMW* curr) { | ||
| //validateAlignment(curr-> |
| //validateAlignment(curr-> | ||
| } | ||
| void WasmValidator::visitAtomicCmpxchg(AtomicCmpxchg* curr) { | ||
| } |
Member
There was a problem hiding this comment.
if there's nothing to validate, these methods can just not be defined?
src/wasm/wasm-validator.cpp
Outdated
| case 2: | ||
| case 4: | ||
| break; | ||
| case 8: |
Member
There was a problem hiding this comment.
the style in other places is
case 8: {
...
break;
}
Contributor
|
Looks generally good modulo @kripken's comments. Nice |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.