Conversation
Member
Author
|
Merging as this blocks other stuff. Feedback still welcome of course. |
binji
reviewed
Oct 20, 2017
| WASM_UNREACHABLE(); | ||
| } | ||
|
|
||
| static Expression* makeSignExt(Expression* value, Index bytes, Module& wasm) { |
Member
There was a problem hiding this comment.
The threads proposal has new instructions for this: https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview.md#new-sign-extending-operators
Member
Author
There was a problem hiding this comment.
Interesting. I guess when we add those to binaryen we can use them to replace makeSignExt etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this, the fuzzer seems to not find anything. So at least the interpreter appears consistent with itself ;)