Update binaryen and several tests for the new br_if operand order.#190
Merged
Update binaryen and several tests for the new br_if operand order.#190
Conversation
src/wasm-s-parser.h
Outdated
| if (i < s.size()) { | ||
| ret->value = expr; | ||
| ret->condition = parseExpression(s[i]); | ||
| } else if (s[0]->str() == BR_IF) { |
Member
Author
|
This PR looks superseded by #189 . |
Member
|
There are changes here not in the previous merged pull, like binary format changes. |
sunfishcode
force-pushed
the
br_if-operand-order
branch
from
4856c61 to
1a4dfbc
Compare
Member
Author
|
You're right. Ok, I've updated and rebased this PR now on top of your PR so it has just the additional changes. |
sunfishcode
force-pushed
the
br_if-operand-order
branch
from
1a4dfbc to
a915829
Compare
Member
|
lgtm if check.py passes |
kripken
added a commit
that referenced
this pull request
Feb 8, 2016
Update binaryen and several tests for the new br_if operand order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates binaryen and many of the tests to use the new br_if operand order (WebAssembly/spec#234). It doesn't update all the auto-generated tests from the spec repo, from llvm, or from the torture tests. I assume those can be done automatically by whatever process updates them.