Add new compound Rtt type #3076
Conversation
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
This is looking great so far 👍
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Very nice! It looks like separating out HeapType was a good move 👍
|
Let me know if you think this is ready for final review. Leaving subtyping to a follow-on PR would be fine, if you'd like. |
|
With the remaining tests added this should be ready for review then :) |
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Looks good to me besides that one last comment. Feel free to land it when it's ready; you should have write access now.
| return array; | ||
| } | ||
| std::string toString() const; | ||
| }; |
There was a problem hiding this comment.
It would be good to move the less trivial methods into the .cpp file. I'm thinking roughly anything with a switch in it. My goal there would be consistency with where the TypeInfo methods are placed.
|
|
2 participants
Extends compound types introduced in #3012 with a representation of
Rtts as described in the GC proposal, by also introducing the concept of aHeapTypeshared betweenTypeInfoandRtt. Again, this should be a non-functional change sinceRtts are not used anywhere yet. Subtyping rules and updating thexrefaliases is left for future work.