Fix DataFlowOpts leaking temporary Functions#3093
Merged
dcodeIO merged 1 commit intoWebAssembly:masterfrom Sep 2, 2020
Merged
Conversation
Contributor
Author
Dangerous half-knowledge, might be wrong. |
kripken
approved these changes
Sep 2, 2020
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm and correct about arena allocation of the body (assuming the arena is properly handled, which I believe it is).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
DataFlowOptsleaking allocated temporary functions created to precompute an expression as their body. Reusing thebodyafterwards is fine because expressions are arena allocated.