Skip to content

[Wasm Exceptions] Fix cfg-traversal on linking the basic block after a call#3594

Merged
kripken merged 1 commit intomainfrom
callblock
Feb 23, 2021
Merged

[Wasm Exceptions] Fix cfg-traversal on linking the basic block after a call#3594
kripken merged 1 commit intomainfrom
callblock

Conversation

@kripken
Copy link
Member

@kripken kripken commented Feb 23, 2021

This was an unfortunate case of the order of execution of call
arguments. link(self->currBasicBlock, self->startBasicBlock()) would
run the call first, which sets currBasicBlock, so we'd end up with
the same value for both parameters.

Without this fix, the testcase would drop the result of the call,
as it thought it had no uses.

Also improve debug logging here a tiny bit.

Found by emscripten-core/emscripten#13485

@kripken kripken requested review from aheejin and tlively February 23, 2021 00:17
Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kripken kripken merged commit b3b6a81 into main Feb 23, 2021
@kripken kripken deleted the callblock branch February 23, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants