Conversation
tlively
approved these changes
Feb 24, 2021
Comment on lines
+353
to
+354
| static_assert(sizeof(Index) == sizeof(int32_t), | ||
| "wasm64 will need changes here"); |
Member
Author
There was a problem hiding this comment.
The data structure here is std::map<Name, Index> internalNames; so I think the idea in the assertion is that wasm64 might need something bigger than an Index if it has over 2^32 names? I agree it should be clarified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this we would assert on hashing e.g.
(br $x)by itself, without thecontext so we recognized the name
$x. Somehow that was not an issueuntil delegate, we just happened to not hash such things. I believe I remember
that @aheejin noticed this issue before, but given we didn't have a testcase,
we deferred fixing it - now is the time, I guess, as with delegate it is easy to
get e.g. CodeFolding to hash a Try with a delegate.
Issue found by emscripten-core/emscripten#13485