[EH] Change Walker::TaskFunc back to function pointer #3899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Walker::TaskFunc` has changed from a function pointer to `std::function` in WebAssembly#3494, mainly to make the EH support for `CFGWalker` easier. We didn't notice much performance difference then, but it was recently reported that it creased binaryen.js code size and performance. This changes `Walker::TaskFunc` back to a function pointer and does a little more work to manage catch index in `CFGWalker` side. Hopefully fixes WebAssembly#3857.
kripken
reviewed
May 20, 2021
aheejin
changed the title
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
Contributor
|
@aheejin thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walker::TaskFunchas changed from a function pointer tostd::functionin #3494, mainly to make the EH support forCFGWalkereasier. We didn't notice much performance difference then, but it was
recently reported that it creased binaryen.js code size and performance.
This changes
Walker::TaskFuncback to a function pointer and does alittle more work to manage catch index in
CFGWalkerside.Hopefully fixes #3857.
cc @MaxGraey