Skip to content

Emit call_ref with a type annotation#5079

Merged
tlively merged 2 commits intomainfrom
call-ref-annotation
Sep 23, 2022
Merged

Emit call_ref with a type annotation#5079
tlively merged 2 commits intomainfrom
call-ref-annotation

Conversation

@tlively
Copy link
Member

@tlively tlively commented Sep 22, 2022

Emit call_ref instructions with type annotations and a temporary opcode. Also
implement support for parsing optional type annotations on call_ref in the text
and binary formats. This is part of a multi-part graceful update to switch
Binaryen and all of its users over to using the type-annotated version of
call_ref without there being any breakage.

@tlively tlively requested a review from kripken September 22, 2022 23:01
@tlively
Copy link
Member Author

tlively commented Sep 22, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@tlively
Copy link
Member Author

tlively commented Sep 22, 2022

cc @jakobkummerow

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % fuzzing

Emit call_ref instructions with type annotations and a temporary opcode. Also
implement support for parsing optional type annotations on call_ref in the text
and binary formats. This is part of a multi-part graceful update to switch
Binaryen and all of its users over to using the type-annotated version of
call_ref without there being any breakage.
@tlively tlively force-pushed the call-ref-annotation branch from 379f60a to d9e3755 Compare September 23, 2022 15:17
@tlively
Copy link
Member Author

tlively commented Sep 23, 2022

Fuzzing now. I added a changelog entry as well.

@tlively tlively enabled auto-merge (squash) September 23, 2022 15:38
@tlively tlively merged commit e09fb56 into main Sep 23, 2022
@tlively tlively deleted the call-ref-annotation branch September 23, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants