Add post-emscripten-side-module pass argument#5274
Merged
Conversation
sbc100
commented
Nov 17, 2022
kripken
reviewed
Nov 17, 2022
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm aside from that Asyncify issue. Let's see what happens with tests.
sbc100
force-pushed
the
post_emscripten_side_module
branch
from
1e7e3d2 to
e555630
Compare
In this mode we don't remove the start/stop_em_asm symbols or data. This is because with side modules we read this information directly from the wasm binaryen at runtime. See emscripten-core/emscripten#18228
sbc100
force-pushed
the
post_emscripten_side_module
branch
from
e555630 to
0f593ed
Compare
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Nov 19, 2022
The only way I could find to make work was to use `eval`. Sadly even using `new Function` didn't work since it evaluates the code not in the containing (module) scope but in the global scope. Depends on WebAssembly/binaryen#5274 Fixes: #18199
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Nov 21, 2022
The only way I could find to make work was to use `eval`. Sadly even using `new Function` didn't work since it evaluates the code not in the containing (module) scope but in the global scope. Depends on WebAssembly/binaryen#5274 Fixes: #18199
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Nov 22, 2022
The only way I could find to make work was to use `eval`. Sadly even using `new Function` didn't work since it evaluates the code not in the containing (module) scope but in the global scope. Depends on WebAssembly/binaryen#5274 Fixes: #18199
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Nov 22, 2022
The only way I could find to make work was to use `eval`. Sadly even using `new Function` didn't work since it evaluates the code not in the containing (module) scope but in the global scope. Depends on WebAssembly/binaryen#5274 Fixes: #18199
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this mode we don't remove the start/stop_em_asm symbols or data. This is because with side modules we read this information directly from the wasm binaryen at runtime.
See emscripten-core/emscripten#18228