Conversation
Member
Author
|
@dschuff: what do you think about landing this? it touches the binary format code a little, I don't want to interfere with your work. |
Member
|
It looks like it doesn't conflict with #711, right? (I mean technically it does touch |
dschuff
reviewed
Sep 26, 2016
check.py
Outdated
| fail(actual, expected) | ||
|
|
||
| binary_format_check(wasm, verify_final_result=False) | ||
| binary_format_check(wasm, verify_final_result = False) |
Member
There was a problem hiding this comment.
Doesn't PEP8 style call for no spaces here?
Member
Author
There was a problem hiding this comment.
I think you're right, will fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #700.
This also needs emscripten repo support (to invoke with
-gwhen appropriate), I'll add that next.This touches wasm-binary.h so it should wait to be rebased and merged after the 0xc binary changes are done.