Conversation
Member
|
In #708 we also saw that the type of exit looks wrong (function type is void, but it has a return statement with a value) - is that an unrelated problem to the one this PR fixes? Separately, can we enable drop validation with this PR? That is, replace the code in src/wasm-validator.h for visitDrop(), which currently checks an env var, with something like |
Member
Author
|
I think the exit type being wrong is a problem with the .s file and not with s2wasm. Also there's one further failure in the wasm-opt tests before we can turn on drop validation: |
Member
|
Ok, thanks, lgtm. I'll investigate that drop validation problem. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #708