[DO NOT MERGE] Custom annotation experiments #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have no real effect on anything, but make easier to compute offsets for branch hinting and other code metadata custom sections
Collaborator
Author
|
closed in favor of #19 |
yuri91
added a commit
that referenced
this pull request
Jun 30, 2023
* [interpreter] Handle custom sections and annotations Co-authored-by: Yuri Iozzelli <y.iozzelli@gmail.com> * Fix merge conflict * Fix lexer priorities * Fix wast.ml * Oops * Update wast.ml --------- Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
yuri91
added a commit
that referenced
this pull request
Jun 30, 2023
* [interpreter] Handle custom sections and annotations Co-authored-by: Yuri Iozzelli <y.iozzelli@gmail.com> * Fix merge conflict * Fix lexer priorities * Fix wast.ml * Oops * Update wast.ml --------- Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exists as a convenient way of looking at my additions to the original PoC for adding custom sections and annotations support to the reference interpreter by @rossberg.
See WebAssembly/design#1445 for a discussion on the topic