This repository was archived by the owner on Nov 3, 2021. It is now read-only.
Conversation
This is copied and modified from this closed PR: #19
rossberg
reviewed
May 28, 2019
Member
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
This looks correct. However, wouldn't it be more appropriate if an eleminst held a vector of references? The expressions from the segment should be evaluated only once, during instantiation of the module.
To model this, instead of a data segment, allocelem would take the vector of refs as parameter, and the evaluation would occur in the module instantiation rule, analogous to the init values for globals.
For symmetry, allocdata should take a plain byte vector as parameter as well.
Member
Author
|
Yes, that makes sense. I'll update the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is copied and modified from this closed PR:
#19