Update Explainer.md to match Wit interface id changes in Binary.md#205
Merged
lukewagner merged 1 commit intomainfrom Jun 20, 2023
Merged
Update Explainer.md to match Wit interface id changes in Binary.md#205lukewagner merged 1 commit intomainfrom
lukewagner merged 1 commit intomainfrom
Conversation
alexcrichton
approved these changes
Jun 17, 2023
Collaborator
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
👍 Thanks for writing this up!
guybedford
approved these changes
Jun 20, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Explainer.md to match the Binary.md/Wit.md changes in #198.
Working on this, I saw a few cases where the grammar for a "version" in Binary.md/Wit.md is a slight subset of what's on semver.org (particularly for
pre-release identifierandbuild identifier). Rather than restating it all verbatim, I thought maybe we could just literally reuse the production (it seems precise enough and I don't think there's anything we need to slice out), so this PR also does that in Binary.md/Wit.md.