Add Wit.md section for resource items#206
Merged
lukewagner merged 2 commits intomainfrom Jun 19, 2023
Merged
Conversation
sunfishcode
reviewed
Jun 17, 2023
| takes and returns a handle to a `blob`: | ||
| ```wit | ||
| resource blob | ||
| transform: func(blob) -> blob |
Member
There was a problem hiding this comment.
Would it make sense to also introduce a function that uses a borrow here, just to introduce the concept, for someone reading this top-down, before launching into more complex examples with borrows below? This would also be a good place to mention the relationship between owned handles and resource lifetimes.
alexcrichton
approved these changes
Jun 17, 2023
Collaborator
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
👍 Makes me realize we need to adjust the parsing in wit-parser a bit, which is good though because I think the syntax here is good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rescues a hunk from #203 that adds a Wit.md section for
resourcedefinitions (including methods).