Merged
Conversation
Collaborator
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! Could use-path reuse the preexisting interface production perhaps? That may require renaming interface, however, since include refers to worlds instead of interfaces.
Contributor
Author
|
@alexcrichton can it take the version as well? The parser accepts it, but I didn't see ui tests for it. If the parser is right, I can improve this and add more tests there. |
Collaborator
|
It can, yeah, and would be good to add tests as well! |
Contributor
Author
|
Okay, so it seems they're the same: interface ::= id
| id ':' id '/' id ('@' valid-semver)?If this is it, then I'll open the PR for the parser once this is merged. |
Contributor
Author
|
It does seem confusing though since it should refer to worlds, but I'll leave it to you. |
cardoso
commented
Sep 11, 2023
Contributor
Author
|
Thanks @alexcrichton . I think it reads better now (and uses the same naming as wit-parser). |
alexcrichton
approved these changes
Sep 13, 2023
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be missing from #174 . I just took a rough look at wit-parser and this seems to be what it's doing currently.
cc @Mossaka @alexcrichton