Restore trap if future.close-writable before future.write succeeds#521
Merged
lukewagner merged 1 commit intomainfrom May 29, 2025
Merged
Restore trap if future.close-writable before future.write succeeds#521lukewagner merged 1 commit intomainfrom
future.close-writable before future.write succeeds#521lukewagner merged 1 commit intomainfrom
Conversation
alexcrichton
added a commit
to alexcrichton/wit-bindgen
that referenced
this pull request
May 27, 2025
To account for WebAssembly/wasip3-prototyping#172 and WebAssembly/component-model#521 the Rust bindings need to take into account that a future writer cannot be dropped without actually writing something. To model this futures now must be created with a thunk that creates the default value to be sent. This value is only used if another value was not otherwise written. Closes bytecodealliance#1304
alexcrichton
approved these changes
May 27, 2025
github-merge-queue bot
pushed a commit
to bytecodealliance/wit-bindgen
that referenced
this pull request
May 27, 2025
To account for WebAssembly/wasip3-prototyping#172 and WebAssembly/component-model#521 the Rust bindings need to take into account that a future writer cannot be dropped without actually writing something. To model this futures now must be created with a thunk that creates the default value to be sent. This value is only used if another value was not otherwise written. Closes #1304
lukewagner
force-pushed
the
future-trap
branch
3 times, most recently
from
6c94096 to
24cb4e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-adds the trapping condition that was accidentally removed in #489 to ensure that a
futuremust successfullyfuture.writea value beforefuture.close-writableing, along with both WAST and Canonical ABI tests.