Clarify import/export identifier validation on the Web.#1028
Merged
sunfishcode merged 1 commit intomasterfrom Apr 4, 2017
Merged
Clarify import/export identifier validation on the Web.#1028sunfishcode merged 1 commit intomasterfrom
sunfishcode merged 1 commit intomasterfrom
Conversation
jfbastien
approved these changes
Mar 30, 2017
Member
|
Text sounds good to me, but perhaps this should in fact be moved to JS.md. |
Member
Author
|
Merging, as this is an improvement over the status quo. I agree that this text feels like it probably should be in JS.md rather than Web.md, but I don't know whether there's a reason it wasn't done this way originally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#970 observed that the mapping of WebAssembly import/export names into JS wasn't specified clearly. This PR clarifies and updates the relevant paragraph in light of #1016 and other changes.