-
Notifications
You must be signed in to change notification settings - Fork 701
Clarify, rename, and FAQ memory allocation #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,8 +108,9 @@ to allow *explicitly* sharing linear memory between multiple modules. | |
| ## Initial state of linear memory | ||
|
|
||
| A module will contain a section declaring the linear memory size (initial and | ||
| maximum size allowed by `sbrk`) and the initial contents of memory (analogous | ||
| to `.data`, `.rodata`, `.bss` sections in native executables). | ||
| maximum size allowed by [`resize_memory`](AstSemantics.md#resizing) and the | ||
| initial contents of memory (analogous to `.data`, `.rodata`, `.bss` sections in | ||
| native executables). | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we want to dictate these, or let wasm handle them but restrict where they can go? As discussed in #285 we can get a no-signal non-page-table but highly-efficient zero-page and
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In a sense, |
||
|
|
||
| ## Code section | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to emphasize this way more: this allows applications to be good citizens and release physical memory. That's a huge win on memory-constrained devices, and is a pretty important feature for many platforms (otherwise the OS is stuck playing favorites with an OOM killer).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point