Mention opcode name syntax for alignment#342
Merged
lukewagner merged 1 commit intomasterfrom Sep 14, 2015
Merged
Conversation
Member
There was a problem hiding this comment.
I think this is a better fit for text format, since it's implicit in the bytecode format?
Member
Author
There was a problem hiding this comment.
Do you mean that you think this para should go in TextFormat.md? I kinda see that point, but opcode names are not just a detail of the text format; they also show up in the SExpr language as the names of AST nodes and will show up in the module local opcode table (which is part of the binary format). AstSemantics is sortof the central hub, so I think it makes sense for it to define the names of opcodes.
Member
There was a problem hiding this comment.
Yeah, but I see your point too. lgtm then :-)
lukewagner
force-pushed
the
add-alignment-syntax
branch
from
80f2c5f to
0890341
Compare
lukewagner
added a commit
that referenced
this pull request
Sep 14, 2015
Mention opcode name syntax for alignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch explains how alignment shows up in the opcode name, so design matches ml-proto.