Conversation
This was slightly contended in the previous PR. Rewrite it and keep it into its own PR.
Rationale.md
Outdated
There was a problem hiding this comment.
This final sentence could be made less Eeyore-esque by saying that we're willing to update the design (before v.1 is finalized) as new stuff comes to light... man. Perhaps: "... but as the MVP stablizes, implementations appear, and we get experience from real-world codebases, we can revisit the alternatives listed below, reevaluate the tradeoffs and potentially update the design in AstSemantics.md before the MVP is finalized."
There was a problem hiding this comment.
Done, I merged and rephrased a bit. Less dude as well ;-)
Rationale.md
Outdated
There was a problem hiding this comment.
I'm not sure it's worth pointing out that the authors believe they have a solid rationale (if they didn't believe that...). I think it would actually flow nicely to just cut out the first part of the sentence (and also "implementations appear, " which now sounds funny) so that you have "As the MVP stabilizes and we get experience from real-world codebases, ...".
|
Great, thanks, lgtm! |
3 participants
This was slightly contended in the previous PR #390. Rewrite it and keep it into its own PR.