Change the argument to grow memory to be in units of pages.#598
Change the argument to grow memory to be in units of pages.#598lukewagner merged 1 commit intomasterfrom unknown repository
Conversation
|
lgtm |
| * `grow_memory` : grow linear memory by a given unsigned delta which | ||
| must be a multiple of the page size. Return the previous memory size. | ||
| * `grow_memory` : grow linear memory by a given unsigned delta of pages. | ||
| Return the previous memory size in bytes. |
There was a problem hiding this comment.
Actually, for consistency the result should also be in pages now?
There was a problem hiding this comment.
Hm, and what about memory_size?
There was a problem hiding this comment.
There seems to be consensus to change the argument to pages so perhaps that could land first and then you could champion a change of the memory_size to pages too in a follow up PR, or do people want it changed here too?
|
As discussed here the spec and the design repos are out of sync until this lands. Any remaining issues here? Sounds like everything should be units of page size? |
|
lgtm (assuming we change return value of |
3 participants
Some support for this change #594
The result is still in units of bytes?