Conversation
As discussed in #629 (comment)
Member
|
This seems like a special case of something we should perhaps state more clearly: resources can become exhausted at literally any time, for any number of reasons. |
Member
Author
|
Indeed, but it's a non-obvious corner case that #629 makes yet-more confusing IMO by discussing virtual reservation guarantees but not physical reservation guarantees (there are no guarantees ;-). Could we handle your suggestion in a separate PR? |
Member
|
Ah, I was missing some context for this PR at first. This lgtm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #629 (comment)